Re: [ANNOUNCE] Kernel Janitor's TODO list

From: David Woodhouse (dwmw2@infradead.org)
Date: Tue Jan 30 2001 - 12:10:39 EST


ttabi@interactivesi.com said:
> What is wrong with sleep_on()?

Are you asking me? If so, why did I not receive a copy in my inbox? If I
want to filter duplicates locally, I can. I don't.

It's almost impossible to use it safely, and the few ways you _can_ use it
safely are frowned upon, because they mostly involve using the BKL, usage of
which is slowly being phased out in favour of finer-grained locking.

This kind of code is far too common:

 if (!event) {
        /* BUT WHAT IF THE EVENT ARRIVES _NOW_? */
         sleep_on(&event_wait);
 }

--
dwmw2

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed Jan 31 2001 - 21:00:35 EST