On Mon, 19 Feb 2001, Marcelo Tosatti wrote:
>
> The following patch makes lock_buffer() use the exclusive wakeup scheme
> added in 2.3.
Ugh, This is horrible.
You should NOT have one function that does two completely different things
depending on a flag. That way lies madness and bad coding habits.
Just do two different functions - make one be "__wait_on_buffer()", and
the other be "__lock_buffer()". See how the page functions work.
Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Fri Feb 23 2001 - 21:00:21 EST