On Mon, 26 Feb 2001, Jens Axboe wrote:
> On Sun, Feb 25 2001, Alexander Viro wrote:
> > Erm... Jens, it really should be
> > if (atomic_dec_and_test(...))
> > up(...);
> > not just
> > atomic_dec(...);
> > up(...);
> >
> > Otherwise you can end up with too early exit of loop_thread. Normally
> > it would not matter, but in pathological cases...
>
> How so? We dec it and up the semaphore, loop_thread runs until it's
> done and ups lo_sem.
You are risking an extra up() here. Think what happens if you already had a
pending request.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Wed Feb 28 2001 - 21:00:10 EST