Re: [PATCH] tiny MM performance and typo patches for 2.4.2

From: Rik van Riel (riel@conectiva.com.br)
Date: Sun Mar 04 2001 - 19:29:05 EST


On Sun, 4 Mar 2001, David S. Miller wrote:
> Ulrich Kunitz writes:
> > patch-uk6 In 2.4.x _page_hashfn divides struct address_space pointer
> > with a parameter derived from the size of struct
> > inode. Deriving this parameter from the size of struct
> > address_space makes more sense -- at least for me.
>
> The address_space is %99 of the time (unless swapping, and in that
> case the address is constant :-)) inside of an inode struct so this
> change actually makes the hash worse. I looked at this one time
> myself...

The other patches look fine to me. Alan, Linus, could
you please include Ulrich's other patches in the next
pre-kernel ?

thanks,

Rik

--
Virtual memory is like a game you can't win;
However, without VM there's truly nothing to lose...

http://www.surriel.com/ http://www.conectiva.com/ http://distro.conectiva.com.br/

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed Mar 07 2001 - 21:00:16 EST