Re: aic7xxx funcs without return values

From: Justin T. Gibbs (gibbs@scsiguy.com)
Date: Wed Mar 07 2001 - 19:53:51 EST

Next message: Greg KH: "Re: Linux 2.4.2ac14"
Previous message: Alan Cox: "Re: Can't compile 2.4.2-ac14"
In reply to: J . A . Magallon: "aic7xxx funcs without return values"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

>Hi,
>
>Just a note to make gcc 2.96 (and future) happy. The aic7xxx driver is full of
>inline funcs that should return a value and do not do that:

They don't return a value because doing so is meaningless. You aren't
going to get past the panic. The compiler should know that assuming
panic is properly tagged as a function that cannot return.

You may also want to check up on your C since having a break after
a return is, well, kinda silly. In all the usage of this inline, the
width is constant, so gcc should completely optimize away the switch
and surrounding code.

--
Justin
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Greg KH: "Re: Linux 2.4.2ac14"
Previous message: Alan Cox: "Re: Can't compile 2.4.2-ac14"
In reply to: J . A . Magallon: "aic7xxx funcs without return values"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Wed Mar 07 2001 - 21:00:25 EST