On Fri, 16 Mar 2001, David Weinehall wrote:
> On Fri, Mar 16, 2001 at 01:07:17PM -0500, Alexander Viro wrote:
> >
> >
> > On Fri, 16 Mar 2001, Alexander Viro wrote:
> >
> > [snip]
> >
> > > Sure. With all its holes and illetarate C.
> > ^
> > e
> > Apparently, rule about typos in spelling flame are not
> > limited to natural languages...
>
> Oh... Was it a typo? I had a good laugh, because I thought it was
> intended. Especially considering that you left one of the typos
> (I was always taught that it's spelled illiterate...)
Original - typo, the rest (including "rule...are") - not ;-)
Seriously, binfmt_misc.c was written in rather, erm, interesting C.
Read it and you'll see. Just one (but rather impressive) example:
if ((count == 1) && !(buffer[0] & ~('0' | '1'))) {
It was meant to be
if (count == 1 && (buffer[0] == '0' || buffer[0] == '1')) {
and anyone who can't find the difference really should learn C. And
that's not the only bogosity of such level. Besides, the thing is
trivially oopsable - write() to any file in binfmt_misc with buffer
pointing to unmapped kernel address and you are screwed,
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Fri Mar 23 2001 - 21:00:09 EST