Trident sound driver - global registers not restored

From: Pavel Roskin (proski@gnu.org)
Date: Mon Mar 19 2001 - 19:57:32 EST


Hello!

The driver for Trident sound cards in 2.4.2-ac20 has functions
ali_save_regs() and ali_restore_regs() that are supposed to save and
restore the hardware registers over the power management events.

ali_restore_regs() restores mixer and channel registers from memory, but
it _saves_ the global registers instead of restoring them:

ali_registers.global_regs[i] = inl(TRID_REG(card, i*4));

It must be an error (most likely a result of cut-and-paste).

Regards,
Pavel Roskin

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Mar 23 2001 - 21:00:13 EST