Re: [PATCH] Prevent OOM from killing init

From: Eli Carter (eli.carter@inet.com)
Date: Wed Mar 21 2001 - 18:11:38 EST


Patrick O'Rourke wrote:
>
> Since the system will panic if the init process is chosen by
> the OOM killer, the following patch prevents select_bad_process()
> from picking init.
>
> Pat
>
> --- xxx/linux-2.4.3-pre6/mm/oom_kill.c Tue Nov 14 13:56:46 2000
> +++ linux-2.4.3-pre6/mm/oom_kill.c Wed Mar 21 15:25:03 2001
> @@ -123,7 +123,7 @@
>
> read_lock(&tasklist_lock);
> for_each_task(p) {
> - if (p->pid) {
> + if (p->pid && p->pid != 1) {
> int points = badness(p);
> if (points > maxpoints) {
> chosen = p;
>

Having not looked at the code... Why not "if( p->pid > 1 )"? (Or can
p->pid can be negative?!, um, typecast to unsigned...)

Eli
-----------------------. Rule of Accuracy: When working toward
Eli Carter | the solution of a problem, it always
eli.carter(at)inet.com `------------------ helps if you know the answer.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Mar 23 2001 - 21:00:16 EST