Re: [PATCH] Prevent OOM from killing init

From: Patrick O'Rourke (orourke@missioncriticallinux.com)
Date: Wed Mar 21 2001 - 18:40:50 EST

Next message: Leif Sawyer: "RE: [PATCH] Prevent OOM from killing init"
Previous message: Kirill Kozmin: "Re: VIA686A chipset crash under 2.4.2-ac20"
In reply to: Eli Carter: "Re: [PATCH] Prevent OOM from killing init"
Next in thread: Leif Sawyer: "RE: [PATCH] Prevent OOM from killing init"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Eli Carter wrote:

> Having not looked at the code... Why not "if( p->pid > 1 )"? (Or can
> p->pid can be negative?!, um, typecast to unsigned...)

I simply mirrored the check done in do_exit():

if (tsk->pid == 1)
panic("Attempted to kill init!");

Since PID_MAX is 32768 I do not believe pids can be negative.

I suppose one could make an argument for skipping "daemons", i.e.
pids below 300 (see the get_pid() function in kernel/fork.c), but
I think that is a larger issue.

Pat

-- Patrick O'Rourke 978.606.0236 orourke@missioncriticallinux.com

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Next message: Leif Sawyer: "RE: [PATCH] Prevent OOM from killing init"
Previous message: Kirill Kozmin: "Re: VIA686A chipset crash under 2.4.2-ac20"
In reply to: Eli Carter: "Re: [PATCH] Prevent OOM from killing init"
Next in thread: Leif Sawyer: "RE: [PATCH] Prevent OOM from killing init"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Fri Mar 23 2001 - 21:00:16 EST