> 1. we take an extra reference on the page, how does that
> affect the test for if the page is shared or not ?
is_page_shared expects us to have our own reference to the page.
> 2. we call delete_from_swap_cache with the pagemap_lru_lock
> held, since this tries to grab the pagecache_lock we can
> easily deadlock with the rest of the kernel (where the
> locking order is opposite)
You're right. Oversight on my part. Here is another version of the
patch.
> 3. there are no comments in the code explaining what this
> suspicious-looking piece of code does ;)
Oops... I sent out the wrong version of the patch the first time. This
one has comments, promise. And it has one less bug. :)
Rich
This archive was generated by hypermail 2b29 : Sat Mar 31 2001 - 21:00:17 EST