Re: [QUESTION] MOD_INC/MOD_DEC: useful to check for correct usage?

From: Alexander Viro (viro@math.psu.edu)
Date: Wed Apr 04 2001 - 20:34:40 EST


On Wed, 4 Apr 2001, Dawson Engler wrote:

> Hi,
>
> in the old days you couldn't call a sleeping function in a module
> before doing a MOD_INC or after doing a MOD_DEC. Then some safety nets
> were added that made these obsolete (in some number of places). I was
> told that people had decided to potentially get rid of all safety
> nets. Is this true? Is it worthwhile to have a checker for these two
> rules?

It's worth removing the MOD_{INC,DEC}_USE_COUNT. Which had been done
in quite a few places. Let the caller handle the refcount on callee -
_that_ is definitely safe.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Apr 07 2001 - 21:00:15 EST