Re: Can't compile 2.4.3 with agcc

From: Matan Ziv-Av (matan@svgalib.org)
Date: Mon Apr 23 2001 - 16:03:26 EST


On Mon, 23 Apr 2001, David Woodhouse wrote:

> --- include/asm/bugs.h 2001/01/18 13:56:53 1.2.2.16
> +++ include/asm/bugs.h 2001/04/23 15:45:28
> @@ -80,8 +80,10 @@
> * Verify that the FXSAVE/FXRSTOR data will be 16-byte aligned.
> */
> if (offsetof(struct task_struct, thread.i387.fxsave) & 15) {
> - extern void __buggy_fxsr_alignment(void);
> - __buggy_fxsr_alignment();
> + printk(KERN_EMERG "ERROR: FXSAVE data are not 16-byte aligned in task_struct.\n");
> + printk(KERN_EMERG "This is usually caused by a buggy compiler (perhaps pgcc?)\n");
> + printk(KERN_EMERG "Cannot continue.\n");
> + for (;;) ;

This is known at compile time, right?
Would it not be better to replace the printk with #error ? Why do I need
to boot the bad kernel to find out that it does not work, when it is
known when compiling?

-- 
Matan Ziv-Av.                         matan@svgalib.org

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Apr 23 2001 - 21:00:47 EST