Re: [PATCH] cleanup for fixing get_super() races

From: Linus Torvalds (
Date: Fri Apr 27 2001 - 20:16:26 EST

On Fri, 27 Apr 2001, Alexander Viro wrote:
> Each of these places is an oopsable race with umount. We can't fix them
> without touching a lot of drivers. However, we can make the future fix
> easier if we put the above into a helper function. Patch below does that.

I don't like the name "ream_inodes()".

Also, a driver shouldn't know about "inodes" and "buffers". It should just
do something like


because the only thing the driver knows about is the _device_.

Then, invalidate_device() might do

        sb = get_super(dev)
        if (sb)
                invalidate_inodes (sb);

which makes some amount of sense. And which can later be extended to deal
with the page cache etc without the drivers ever knowing or caring.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

This archive was generated by hypermail 2b29 : Mon Apr 30 2001 - 21:00:19 EST