RE: 2.4.4, 2.4.4-ac1 and -ac3: oops loading future domain scsi mo dule

From: Matt_Domsch@Dell.com
Date: Wed May 02 2001 - 07:24:35 EST


> > + if(pdev!=NULL)
> > scsi_set_pci_device(shpnt->pci_dev, pdev);
>
> I suspect it should be
>
> if(shpnt->pci_dev)
>
> but the effect is identical

That one's mine. It should be:
   scsi_set_pci_device(shpnt, pdev);

There's no reason to check if pdev != NULL first, as it's NULL in the
structure beforehand, and NULL afterward.

I'll fix and submit a patch, and make sure I didn't make the same mistake
elsewhere too.

Thanks,
Matt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon May 07 2001 - 21:00:13 EST