On 11 May 01 at 12:32, Andi Kleen wrote:
> On Fri, May 11, 2001 at 12:21:59PM +0000, Petr Vandrovec wrote:
> > When I was updating VMware's vmnet, I decided to use
> >
> > #ifdef skb_shinfo
>
> Yes I forgot that RedHat already shipped it :-(
Not only that RedHat shipped it, but thousands of people used Alan's
patches since 25th February. So you cannot check kernel version for >=2.4.4.
> > This gives you maximal backward compatibility, as all public zerocopy
> > patches contain this macro. Only thing is that Dave has to remember
> > that when he turns skb_shinfo into inline function, an identity #define have
> > to be added.
>
> No such guarantee for binary only software ;)
vmnet is GPLed software, if you did not notice ;-) Fortunately change
went into Alan tree first, so I noticed long before 2.4.4 came out. Although
it took nonzero effort to persuade others that it will go into Linus's 2.4.x
even if it breaks API. They did not trust me that source compatibility
in stable series is only a wish.
Petr Vandrovec
vandrove@vc.cvut.cz
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Tue May 15 2001 - 21:00:26 EST