Keith Owens wrote:
>
> On Sat, 19 May 2001 17:58:49 -0400,
> Jeff Garzik <jgarzik@mandrakesoft.com> wrote:
> >Finally, I don't know if I mentioned this earlier, but to be complete
> >and optimal, version strings should be a single variable 'version', such
> >that it can be passed directly to printk like
> >
> > printk(version);
>
> Nit pick. That has random side effects if version contains any '%'
> characters. Make it
>
> printk("%s\n", version);
>
> Not quite as optimal but safer.
I disagree. Don't work around an escape bug in a version string, fix
it...
-- Jeff Garzik | "Do you have to make light of everything?!" Building 1024 | "I'm extremely serious about nailing your MandrakeSoft | step-daughter, but other than that, yes." - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Wed May 23 2001 - 21:00:35 EST