Re: [CHECKER] 2.4.5-ac4 non-init functions calling init functions

From: Dawson Engler (engler@csl.Stanford.EDU)
Date: Wed May 30 2001 - 18:01:03 EST


> > drivers/mtd/docprobe.c:195:DoC_Probe: ERROR:INIT: non-init fn
> > 'DoC_Probe' calling init fn 'doccheck'
>
> Strictly speaking, not actually a bug. DoC_Probe() itself is only ever
> called from __init code. But it's probably not worth trying to make the
> checker notice that situation - I've fixed it anyway by making DoC_Probe()
> __init too, which saves a bit more memory. Thanks.

It's a space/performance bug, though, right? From the original mail:

        1. The best case: the caller should actually be an __init function
        as well. This is a performance bug since it won't be freed.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu May 31 2001 - 21:00:49 EST