Re: [NFS] Re: [RFC] yet another knfsd-reiserfs patch

From: Chris Mason (mason@suse.com)
Date: Sat Jun 02 2001 - 12:00:15 EST


On Saturday, June 02, 2001 12:19:59 AM +0200 Trond Myklebust
<trond.myklebust@fys.uio.no> wrote:

>
> Hi Chris,
>
> Do you really need the parent inode in the filehandle?
>
> That screws rename up pretty badly, since the filehandle changes when
> you rename into a different directory. It means for instance that when
> I do
>
> open(foo)
> mv foo bar/
> write (foo)
> close(foo)
>
> then I have a pretty good chance of getting an ESTALE on the write()
> statement.
>

Hmmm, didn't realize I had only answered this in private mail.

The patch doesn't change when the parent dir's ino is included in the
filehandle, it just adds wrappers for storing it and getting it out.

For ext2, the parent inum is only sent for files when the subtree checks
are turned on (_fh_update is unchanged if no fill_fh func is provided).

The reiserfs one always puts the parent inum into the fh, but
find_fh_dentry only pulls it out for directories or subtree checks so I
didn't add the extra logic to the reiserfs fill_fh func.

-chris

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Jun 07 2001 - 21:00:21 EST