Re: [PATCH] swapin flush cache bug

From: NIIBE Yutaka (gniibe@m17n.org)
Date: Fri Jun 29 2001 - 09:18:00 EST


NIIBE Yutaka wrote:
> I'll close the entry for MM bugzilla, it's not MM bug.

I've closed the entry. It is SuperH cache flushing issue at I/O.

Then, thinking again, I think that my argument for do_swap_page() is
still valid.

        When the page is swapped in, the cache for the page is flushed
        __only if__ it's not found in swap cache.

I don't see any reason why we need to flush the cache here.

--- v2.4.6-pre5/mm/memory.c Mon Jun 25 18:48:10 2001
+++ kernel/mm/memory.c Tue Jun 26 14:48:15 2001
@@ -1109,8 +1109,6 @@ static int do_swap_page(struct mm_struct
                         return -1;
                 }
                 wait_on_page(page);
- flush_page_to_ram(page);
- flush_icache_page(vma, page);
         }
 
         /*

-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Jun 30 2001 - 21:00:22 EST