Re: compile error about do_softirq in 2.4.5-ac21

From: Byeong-ryeol Kim (jinbo21@hananet.net)
Date: Sat Jun 30 2001 - 14:37:08 EST

On Sun, 1 Jul 2001, Byeong-ryeol Kim wrote:

>On Sat, 30 Jun 2001, Keith Owens wrote:
>
>>On Sat, 30 Jun 2001 10:07:20 +0900 (KST),
>>Byeong-ryeol Kim <jinbo21@hananet.net> wrote:
>>>>>background.c:57: `do_softirq_Rf0a529b7' undeclared (first use in \
>>>>> this function)
>>
>>Missing include in fs/jffs2/background.c. spin_unlock_bh() needs the
>>definition of do_softirq(). Against 2.4.5-ac21, will fit -ac22 as well.
>>
>>Index: 5.52/fs/jffs2/background.c
>>--- 5.52/fs/jffs2/background.c Sun, 22 Apr 2001 07:25:55 +1000 kaos (linux-2.4/Z/d/7_background 1.1 644)
>>+++ 5.52(w)/fs/jffs2/background.c Sat, 30 Jun 2001 14:13:12 +1000 kaos (linux-2.4/Z/d/7_background 1.1 644)
>>@@ -43,6 +43,7 @@
>> #include <linux/jffs2.h>
>> #include <linux/mtd/mtd.h>
>>+#include <linux/interrupt.h>
>> #include <linux/smp_lock.h>
>> #include "nodelist.h"
>...
>
>Thank you.
>But, it is proved to be that jffs2/background.c includes 'linux/smp_lock.h',
>'linux/smp_lock.h' includes 'asm/smplock.h' and 'asm/smplock.h' includes
>'linux/interrupt.h'.
>Is it correct to put 'linux/interrupt.h' into jffs2/background.c in this
>situation?
...

Please, ignore my previous mail about 'linux/interrupt.h'.
I bypassed the '#ifndef CONFIG_SMP ... #endif' wrapper in linux/smp_lock.h.

...
#ifndef CONFIG_SMP

#define lock_kernel() do { } while(0)
#define unlock_kernel() do { } while(0)
#define release_kernel_lock(task, cpu) do { } while(0)
#define reacquire_kernel_lock(task) do { } while(0)
#define kernel_locked() 1

#else

#include <asm/smplock.h>

#endif /* CONFIG_SMP */
...

Thanks, 

-- 
Where there is a will, there is a way.       jinbo21@hananet.net
  For the future of you and me!              jinbo21@hitel.net
fingerprint = 1429 8AAF 8A2C 6043 DA2E  BD4C 964C 2698 687D 4B7D

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Sat Jun 30 2001 - 21:00:24 EST