On Fri, 6 Jul 2001, Chris Friesen wrote:
> Subject: why this 1ms delay in mdio_read? (cont'd from "are ioctl calls
supposed to take this long?")
>
> The beginning of mdio_read() in tulip.c goes like this:
>
> static int mdio_read(struct device *dev, int phy_id, int location)
...
> mdelay(1); /* One ms delay... */
Ackkk! What driver version?
And who put this bogus delay in the code?
Putting arbitrary delays in drivers is usually a sign that the someone
didn't understand how to fix a bug and is just trying to wait it out.
> The chip I'm using is the DEC 21143, which means that we skip over the two
> conditional blocks, so the first thing that happens when we call this is to
> wait around doing nothing for a millisecond. Is there some subtle
> reason why we would want to wait around for a millisecond before doing
> anything?
Nope. None at all.
Donald Becker becker@scyld.com
Scyld Computing Corporation http://www.scyld.com
410 Severn Ave. Suite 210 Second Generation Beowulf Clusters
Annapolis MD 21403 410-990-9993
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sat Jul 07 2001 - 21:00:19 EST