Re: [PATCH] Separate global/perzone inactive/free shortage

From: Marcelo Tosatti (marcelo@conectiva.com.br)
Date: Sat Jul 14 2001 - 02:11:21 EST


There is a silly typo on the patch.

On Sat, 14 Jul 2001, Marcelo Tosatti wrote:

>
> Hi,
>
> As well known, the VM does not make a distiction between global and
> per-zone shortages when trying to free memory. That means if only a given
> memory zone is under shortage, the kernel will scan pages from all zones.
>
> The following patch (against 2.4.6-ac2), changes the kernel behaviour to
> avoid freeing pages from zones which do not have an inactive and/or
> free shortage.
>
> Now I'm able to run memory hogs allocating 4GB of memory (on 4GB machine)
> without getting real long hangs on my ssh session. (which used to happen
> on stock -ac2 due to exhaustion of DMA pages for networking).
>
> Comments ?
>
> Dirk, Can you please try the patch and tell us if it fixes your problem ?
>
>

mm/vmscan.c diff

> @@ -574,8 +593,13 @@
> * If we're freeing buffer cache pages, stop when
> * we've got enough free memory.
> */
> - if (freed_page && !free_shortage())
> - break;
> + if (freed_page) {
> + if (zone) {
> + if (!zone_free_shortage(zone))
> + break;
> + } else if (free_shortage())
                                          ^^^^^^^^ ^^^^^^
Should be
                                } else if (!free_shortage())

> + break;
> + }
> continue;

Well, updated patch at
http://bazar.conectiva.com.br/~marcelo/patches/v2.4/2.4.6ac2/zoned.patch

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Jul 15 2001 - 21:00:20 EST