On Sat, 4 Aug 2001, Petr Vandrovec wrote:
> Hi Alan,
> double-unlock on sb_lock in try_to_sync_unused inodes when
> try_to_sync_unused_list() returns 0... It is reliably
> triggered by xmms loading mp3 tags from vfat...
>
> Originally from 2.4.7-ac4, but still unfixed in -ac5.
Thanks for spotting. Hell knows where that break; had come from - in
namespaces-patch we do return; in that place and that what should've
been in the splitup that went into -ac. My apologies...
> diff -urdN linux/fs/inode.c linux/fs/inode.c
> --- linux/fs/inode.c Sat Aug 4 00:02:18 2001
> +++ linux/fs/inode.c Sat Aug 4 17:37:50 2001
> @@ -412,7 +412,7 @@
> continue;
> spin_unlock(&sb_lock);
> if (!try_to_sync_unused_list(&sb->s_dirty))
> - break;
> + return;
> spin_lock(&sb_lock);
> }
> spin_unlock(&sb_lock);
Yup. Alan, apply it, please.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Tue Aug 07 2001 - 21:00:33 EST