Re: linux-2.4.9: atomic_dec_and_lock sometimes used while not defined

From: Christoph Hellwig (hch@ns.caldera.de)
Date: Fri Aug 17 2001 - 05:31:10 EST

Hi Trond,

In article <shsu1z7c7qa.fsf@charged.uio.no> you wrote:
> diff -u --recursive --new-file linux-2.4.9.orig/lib/Makefile linux-2.4.9/lib/Makefile
> --- linux-2.4.9.orig/lib/Makefile Wed Apr 25 22:31:03 2001
> +++ linux-2.4.9/lib/Makefile Fri Aug 17 11:52:35 2001
> @@ -16,6 +16,7 @@
> obj-$(CONFIG_RWSEM_XCHGADD_ALGORITHM) += rwsem.o
>
> ifneq ($(CONFIG_HAVE_DEC_LOCK),y)
> + export-objs += dec_and_lock.o
> obj-y += dec_and_lock.o
> endif

Nonono! Please add it to export-objs _always_ not dependand on some
CONFIG_ symbol, that's how the 2.4 makefiles work.

        Christoph 

-- 
Of course it doesn't work. We've performed a software upgrade.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Thu Aug 23 2001 - 21:00:22 EST