>
> int __init msr_init(void)
> {
> +#ifdef CONFIG_DEVFS_FS
> + devfs_handle = devfs_register(NULL, "cpu/msr", DEVFS_FL_DEFAULT, 0, 0,
> + S_IFREG | S_IRUGO | S_IWUSR,
> + &msr_fops, NULL);
> +#else
> if (register_chrdev(MSR_MAJOR, "cpu/msr", &msr_fops)) {
> printk(KERN_ERR "msr: unable to get major %d for msr\n",
> MSR_MAJOR);
> return -EBUSY;
> }
> +#endif
this must be wrong as you don't check for devfs_register failures...
Also why devfs can't just use register_chrdev and not touch ALL drivers
is beyond me, but it has been like that for a while now...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Fri Aug 31 2001 - 21:00:23 EST