On Tue, 28 Aug 2001, Marcelo Tosatti wrote:
> On 28 Aug 2001, Andi Kleen wrote:
> > Marcelo Tosatti <marcelo@conectiva.com.br> writes:
> >
> > > --- linux.orig/fs/buffer.c Mon Aug 27 20:46:36 2001
> > > +++ linux/fs/buffer.c Mon Aug 27 21:43:35 2001
> > > @@ -2448,6 +2448,10 @@
> > > write_unlock(&hash_table_lock);
> > > spin_unlock(&lru_list_lock);
> > > if (gfp_mask & __GFP_IO) {
> > > +#ifdef CONFIG_HIGHMEM
> > > + if (!(gfp_mask & __GFP_HIGHIO) & PageHighMem(page))
> > ^^
> > Should clearly be &&
> > Could be a problem if PageHighMem returns something other than 1 for true.
>
> Right.
>
> Linus, please fix that on your tree.
It would also look nicer without the #ifdef CONFIG_HIGHMEM and #endif:
remember that mm.h defines PageHighMem(page) as 0 ifndef CONFIG_HIGHMEM,
so (I hope) it would all get optimized away in that case.
Hugh
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Fri Aug 31 2001 - 21:00:28 EST