Re: Linux 2.4.10-pre6

From: Stephen Frost (sfrost@snowman.net)
Date: Sun Sep 09 2001 - 18:43:13 EST


* Linus Torvalds (torvalds@transmeta.com) wrote:
>
> Most noticeable (except perhaps for the NTFS update if you're a NTFS user)
> is that the broken bootdata patch that could cause some spurious MM
> corruption due to a double page free of the bootdata got reverted. This is
> the one that caused BUG reports from mm/page_alloc.c..

        The changes to rd.c cause it to fail in compiling. Following
        is a patch which I believe to be correct. It fixes the
        compilation problem and the module appears to load, work and
        unload correctly.

                Stephen

--- linux-2.4.10-pre6-orig/drivers/block/rd.c Sun Sep 9 16:19:07 2001
+++ linux/drivers/block/rd.c Sun Sep 9 16:06:59 2001
@@ -259,7 +259,7 @@
                         /* special: we want to release the ramdisk memory,
                            it's not like with the other blockdevices where
                            this ioctl only flushes away the buffer cache. */
- if ((atomic_read(rd_bdev[minor]->bd_openers) > 2))
+ if ((atomic_read(&rd_bdev[minor]->bd_openers) > 2))
                                 return -EBUSY;
                         destroy_buffers(inode->i_rdev);
                         rd_blocksizes[minor] = 0;
@@ -372,7 +372,7 @@
                 struct block_device *bdev = rd_bdev[i];
                 rd_bdev[i] = NULL;
                 if (bdev) {
- blkdev_put(bdev);
+ blkdev_put(bdev, BDEV_FILE);
                         bdput(bdev);
                 }
                 destroy_buffers(MKDEV(MAJOR_NR, i));



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Sep 15 2001 - 21:00:21 EST