Re: [PATCH] modutils: ieee1394 device_id extraction

From: Artur Frysiak (wiget@pld.org.pl)
Date: Mon Sep 17 2001 - 06:15:40 EST

Next message: pascal.lengard@wanadoo.fr: "2.4.9 Oops - no more sockets"
Previous message: Michael Dreher: "2.4.9 deadlock"
In reply to: Kristian Hogsberg: "Re: [PATCH] modutils: ieee1394 device_id extraction"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Sun, Sep 16, 2001 at 12:18:53PM +0200, Kristian Hogsberg wrote:
> @@ -1225,6 +1306,8 @@
> if (usbmap != stdout)
> fclose(usbmap);
> if (parportmap != stdout)
> + fclose(parportmap);
> + if (ieee1394map != stdout)
> fclose(parportmap);
> /* Close depfile last, it's timestamp is critical */
> if (dep != stdout)

I think, this part is bad. You test for ieee139map file pointer and close
parportmap.

Regards

-- 
Artur Frysiak
http://www.pld.org.pl/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: pascal.lengard@wanadoo.fr: "2.4.9 Oops - no more sockets"
Previous message: Michael Dreher: "2.4.9 deadlock"
In reply to: Kristian Hogsberg: "Re: [PATCH] modutils: ieee1394 device_id extraction"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sun Sep 23 2001 - 21:00:19 EST