Re: RFC (patch below) Re: ide drive problem?

From: Mark Hahn (
Date: Sat Sep 29 2001 - 15:48:00 EST

> This is an error that I am considering removing form the user's view.
> For the very fact/reason you are pointing out; however, it becomse
> more painful when performing error sorting.

yes, most of the time, the warning scares people unnecessarily.
but if the machine is seeing lots of CRC failures, there should
definitely be some prominent messages. perhaps something simple
like producing a warning if more than a few of recent IOs
have had CRC problems:

int crcState = 0;

on successful IO:
        crcState >>= 1;

on CRC failure:
        if (crcState)
                printk("dang, CRC failed on hda, see http://whatever");
        crcState = 1 << 10;

so if >10 IOs succeed between CRC failures, there's no warning.
(uh, I guess that would actually be 9, since presumably the retry
would succeed...) keeping a global count of CRC failures would be
kind of nice, too.

regards, mark hahn.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

This archive was generated by hypermail 2b29 : Sun Sep 30 2001 - 21:01:10 EST