Re: [PATCH] Intel 830 support for agpgart

From: Christof Efkemann (efkemann@uni-bremen.de)
Date: Tue Oct 02 2001 - 08:10:51 EST


On 01 Oct 2001 22:02:08 -0400
Robert Love <rml@tech9.net> wrote:

> You don't need all that code. If agp_try_unsupported works, then
> intel_generic_setup works, so you don't need an intel_830_setup.
>
> In other words, if agp_try_unsupported=1 makes everything OK, then you
> just need to add the detection code.
>
> Thus, the patch becomes the following. Give that a try.

Yes, that seems to work as well. Although there are two minor things I
noticed:
- First, intel_generic_setup sets num_aperture_sizes to 7, while the i830
  has only 4 valid values (32 to 256 MB).
- Second, when intel_generic_configure clears the error status register, it
  resets bits 8, 9 and 10. With an i830 it should clear bits 2, 3 and 4.

So I'm not sure if this works in general, or could it cause errors on other
systems?

-- 
Regards,
Christof Efkemann
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Oct 07 2001 - 21:00:21 EST