Re: [PATCH] Re: bug? in using generic read/write functions to read/write block devices in 2.4.11-pre2

From: Christoph Hellwig (hch@ns.caldera.de)
Date: Wed Oct 03 2001 - 16:56:19 EST


Hi Al,

In article <Pine.GSO.4.21.0110031643130.23558-100000@weyl.math.psu.edu> you wrote:
> Moreover, ->release() for block_device also doesn't care for the junk
> we pass - it only uses inode->i_rdev. In all cases. And I'd rather
> see it them as
> int (*open)(struct block_device *bdev, int flags, int mode);
> int (*release)(struct block_device *bdev);
> int (*check_media_change)(struct block_device *bdev);
> int (*revalidate)(struct block_device *bdev);
> - that would make more sense than the current variant. They are block_device
> methods, not file or inode ones, after all.

How about starting 2.5 with that patch ones 2.4.11 is done? Linus?

        Christoph

-- 
Of course it doesn't work. We've performed a software upgrade.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Oct 07 2001 - 21:00:29 EST