Re: 2.4.14 doesn't compile: deactivate_page not defined in loop.c

From: Andrea Arcangeli (andrea@suse.de)
Date: Mon Nov 05 2001 - 20:50:56 EST


On Mon, Nov 05, 2001 at 05:35:17PM -0800, Chris Wright wrote:
> * David Dyck (dcd@tc.fluke.com) wrote:
> >
> >
> > drivers/block/block.o: In function `lo_send':
> > drivers/block/block.o(.text+0x8ad9): undefined reference to `deactivate_page'
> > drivers/block/block.o(.text+0x8b19): undefined reference to `deactivate_page'
> >
> >
> > a grep from deactivate_page only shows up in linux/drivers/block/loop.c
>
> appears that deactivate_page was removed (see patch-2.4.14). the patch
> below Works For Me with limited testing (mount loop back, write,
> unmount, remount, stuff i wrote is still there ;-). YMMV.

no idea why deactivate_page disappeared, it made sense to deactivate the
lower level cache, it doesn't worth to keep two caches with duplicate
information, the higher level cache is faster so we'd better get rid of
the lowlevel cache ASAP, hence the deactivate_page in loop.c.

Andrea
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed Nov 07 2001 - 21:00:28 EST