Pete Zaitcev wrote:
>what do you think about the attached patch. Without it,
>a sysctl to kernel.real-root-dev corrupts adjacent memory.
I agree that this looks broken, but I don't see why it
would be s390 specific. The clobber of adjacent memory
happens on all architectures, and on all big endian systems
the value read is incorrect even if adjacent memory happens
to be 0.
However, I'm not convinced the patch is a proper fix; it
will cause the MAJOR and MINOR macros to be applied to a
variable not of type kdev_t, which happens to work now but will
break if the definition of kdev_t is changed to a structure
or pointer type (as it probably will at some point in the
future, if I recall the various discussions correctly).
What about either
- adding support for kdev_t values to procfs
or
- keeping two int variables real_root_major and
real_root_minor ?
Bye,
Ulrich
-- Dr. Ulrich Weigand weigand@informatik.uni-erlangen.de - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Thu Nov 15 2001 - 21:00:24 EST