Re: VM-related Oops: 2.4.15pre1

From: Andrea Arcangeli (andrea@suse.de)
Date: Sat Nov 17 2001 - 23:10:23 EST


On Sat, Nov 17, 2001 at 07:12:51PM -0800, Linus Torvalds wrote:
> In article <20011117225327.5368.qmail@thales.mathematik.uni-ulm.de> you write:
> >
> >I think this one liner (diffed against 2.4.14) could fix this Oops:
>
> It really shouldn't matter - at that point we have the page locked, and

I also agree the patch shouldn't matter, but one suspect thing is the
fact add_to_swap_cache goes to clobber in a non atomic manner the page
lock. so yes, we hold the page lock both in swap_out and in
shrink_cache, but swap_out can drop it for a moment and then later
pretend to be the onwer again without a real trylock.

Andrea
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Nov 23 2001 - 21:00:17 EST