Re: [BUG] Bad #define, nonportable C, missing {}

From: Tim Waugh (twaugh@redhat.com)
Date: Wed Nov 21 2001 - 06:16:15 EST

Next message: Alastair Stevens: "Re: Athlon /proc/cpuinfo anomaly [minor]"
Previous message: Alan Cox: "Re: Athlon /proc/cpuinfo anomaly [minor]"
In reply to: vda: "[BUG] Bad #define, nonportable C, missing {}"
Next in thread: Vincent Sweeney: "Re: [BUG] Bad #define, nonportable C, missing {}"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Wed, Nov 21, 2001 at 12:40:17PM +0000, vda wrote:

> drivers/block/paride/pf.c: if (l==0x20) j--; targ[j]=0;
> drivers/block/paride/pg.c: if (l==0x20) j--; targ[j]=0;
> drivers/block/paride/pt.c: if (l==0x20) j--; targ[j]=0;
> (these files need Lindenting too)
> ----------
> Missing {}
> Either a bug or a very bad style (so bad that I can even imagine
> that it is NOT a bug). Please double check before applying the patch!

This seems to be just bad indentation rather than a bug. 'targ[j]=0'
seems to have the purpose of zero-terminating the string, if you look
at the callers of those functions. (But yes, the code is extremely
hard to read, and I can't convince myself either way about whether the
|| two lines earlier should or shouldn't be an &&.)

Tim.
*/

application/pgp-signature attachment: stored

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Next message: Alastair Stevens: "Re: Athlon /proc/cpuinfo anomaly [minor]"
Previous message: Alan Cox: "Re: Athlon /proc/cpuinfo anomaly [minor]"
In reply to: vda: "[BUG] Bad #define, nonportable C, missing {}"
Next in thread: Vincent Sweeney: "Re: [BUG] Bad #define, nonportable C, missing {}"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Fri Nov 23 2001 - 21:00:27 EST