Re: [PATCH] direct IO breaks root filesystem

From: Linus Torvalds (
Date: Mon Dec 10 2001 - 00:55:57 EST

On Mon, 10 Dec 2001, GOTO Masanori wrote:
> The reason is that when kernel accesses /dev/sda with O_DIRECT,
> blkdev_direct_IO() is called. But, it calls generic_direct_IO(),
> and generic_direct_IO() calls brw_kiovec(..., inode->i_dev, ...).

That's a bad bug, yes.

However, the bug is really in "generic_direct_IO()", and you should fix it
there, instead of avoiding to use it altogether.

"generic_direct_IO()" should just get the device from "bh->b_dev (which is
filled in correctly by "get_block()".


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

This archive was generated by hypermail 2b29 : Sat Dec 15 2001 - 21:00:16 EST