OK, I talked to Andrew off-list and we agree his fix is more correct.
It should be applied. I tested it (I have a consistent method of
reproducing the race under preempt-kernel) and it works.
I rediffed it against pre8 because I had trouble applying his, oddly.
Ignore previous patch. Marcelo, please apply. Seriously, this time.
--- linux-2.4.17-pre8/drivers/char/console.c Mon Dec 10 20:48:50 2001
+++ linux/drivers/char/console.c Tue Dec 11 02:52:44 2001
@@ -100,6 +100,7 @@
@@ -2348,17 +2349,25 @@
+ * we can race here against con_close, so we grab the bkl
+ * and check the pointer before calling set_cursor
static void con_flush_chars(struct tty_struct *tty)
- struct vt_struct *vt = (struct vt_struct *)tty->driver_data;
+ struct vt_struct *vt;
if (in_interrupt()) /* from flush_to_ldisc */
+ vt = (struct vt_struct *)tty->driver_data;
+ if (vt)
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to email@example.com
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sat Dec 15 2001 - 21:00:19 EST