Re: [PATCH] v2.5.1-pre9-00_kvec.diff

From: Hugh Dickins (hugh@veritas.com)
Date: Tue Dec 11 2001 - 18:33:32 EST


On Tue, 11 Dec 2001, Benjamin LaHaise wrote:
>
> Since the big block melee has started pretty quickly, I'd like to try
> to start reeling things in so that they aren't off on a tangent that
> completely excludes the requirements of aio and the revamped kiobufs
> that were discussed earlier. To that end, I'm offering up the below
> patch that adds the kvec structure and helpers so that we can begin
> converting kiobuf users, as well as networking and the newly introduced
> bio_vecs into a unified set of primatives. Comments?

Looks nice, but I think you need to update from atomic_inc(&map->count)
and __free_page(map) to page_cache_get(map) and page_cache_release(map)?
I haven't checked a 2.5.1-pre9 tree, but we had to change that in 2.4,
to avoid PageLRU BUGs. page_cache_get end just tidiness, of course.

Hugh

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Dec 15 2001 - 21:00:22 EST