Re: [PATCH] v2.5.1-pre9-00_kvec.diff

From: Benjamin LaHaise (bcrl@redhat.com)
Date: Tue Dec 11 2001 - 22:37:11 EST

Next message: Bongani Hlope: "Re: [Patch] Compilation errors on some usb file"
Previous message: Steven Walter: "Re: [PATCH] v2.5.1-pre9-00_kvec.diff"
In reply to: Steven Walter: "Re: [PATCH] v2.5.1-pre9-00_kvec.diff"
Next in thread: Roman Zippel: "Re: [PATCH] v2.5.1-pre9-00_kvec.diff"
Reply: Roman Zippel: "Re: [PATCH] v2.5.1-pre9-00_kvec.diff"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Tue, Dec 11, 2001 at 09:35:15PM -0600, Steven Walter wrote:
> > + nr_pages = (ptr + len + PAGE_SIZE - 1) >> PAGE_SHIFT;
> > + nr_pages -= ptr >> PAGE_SHIFT;
>
> Isn't this the same as
> nr_pages = (len + PAGE_SIZE -1) >> PAGE_SHIFT;

No.

> ? Or am I missing something?

Yes. Pointers may not be page aligned.

-ben

-- 
Fish.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Bongani Hlope: "Re: [Patch] Compilation errors on some usb file"
Previous message: Steven Walter: "Re: [PATCH] v2.5.1-pre9-00_kvec.diff"
In reply to: Steven Walter: "Re: [PATCH] v2.5.1-pre9-00_kvec.diff"
Next in thread: Roman Zippel: "Re: [PATCH] v2.5.1-pre9-00_kvec.diff"
Reply: Roman Zippel: "Re: [PATCH] v2.5.1-pre9-00_kvec.diff"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sat Dec 15 2001 - 21:00:22 EST