Re: radeonfb fix, fixed

From: Dave Jones (davej@suse.de)
Date: Mon Jan 14 2002 - 18:38:45 EST


On Sun, 13 Jan 2002, Erik Andersen wrote:

> > This patch is needed to make radeonfb compile and work.
> > It is based on an earlier patch on the list attributed to
> > Ani Joshi, plus adds the needed devinit fix.
> Oops. That patch had some crap in it. Lets try that again.

Uncompressed, that patch was just 4kb. When not too big, it's
considered acceptable (and preferred) to send them as plaintext
to the list for ease of quoting.

Patch looks ok, but this bit..

diff -urN linux/drivers/video.virgin/radeonfb.c
linux/drivers/video/radeonfb.c
--- linux/drivers/video.virgin/radeonfb.c Sun Jan 13 19:09:54 2002
+++ linux/drivers/video/radeonfb.c Sun Jan 13 19:41:00 2002
@@ -686,7 +686,7 @@
    name: "radeonfb",
    id_table: radeonfb_pci_table,
    probe: radeonfb_pci_register,
- remove: radeonfb_pci_unregister,
+ remove: __devexit_p(radeonfb_pci_unregister),
 };

Is that really needed ? Hotplugable radeons ?

Dave.

-- 
| Dave Jones.        http://www.codemonkey.org.uk
| SuSE Labs

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Jan 15 2002 - 21:00:48 EST