Re: [Linux-fbdev-devel] [PATCH] fbdev fbgen cleanup

From: Geert Uytterhoeven (geert@linux-m68k.org)
Date: Wed Jan 23 2002 - 12:41:38 EST

On Wed, 23 Jan 2002, Sven wrote:
> On Wed, Jan 23, 2002 at 06:34:03PM +0100, Geert Uytterhoeven wrote:
> > On Wed, 23 Jan 2002, Sven wrote:
> > > Also, since when does the B_FREE or NODEV exists ? I did put the changes into
> > > a #ifdef kernel 2.5, and kept the -1 for kernels 2.4, but i guess i could
> > > remove this check altogether if the NODEV was present from the begining. And
> >
> > IIRC, Marcelo added NODEV to 2.4.x in one of his latest releases, just to solve
> > this problem.
> >
> > > what about 2.2 kernels ?
> >
> > No idea. Ask Alan :-)
>
> Ok, so the best thing would be to keep the #ifdef then.
>
> or maybe i could try an :
>
> #ifdef NODEV
> ..node = NODEV
> #else
> ..node = -1
> #endif
>
> ?

Or even shorter (and cleaner, IMHO):

#ifndef NODEV
#define NODEV -1
#endif

Gr{oetje,eeting}s,

                                                Geert 

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Wed Jan 23 2002 - 21:01:05 EST