On Thu, Jan 31, 2002 at 04:39:11PM -0800, James Simmons wrote:
> > > This patch ports q40 PS/2 controller support over to the input api. Please
> > > try it out. It is against the latest dave jones tree.
> >
> > thanks, I will look at this over the weekend. Where do I get the DJ
> > tree?
>
> ftp://ftp.kernel.org/pub/linux/kernel/people/davej/patches/2.5
>
>
> > > +static inline void q40kbd_write(unsigned char val)
> > > +{
> > > + /* FIXME! We need a way how to write to the keyboard! */
> > > +}
> >
> > absolutely no way to write to the keyboard.
>
> That solves that.
It doesn't. atkbd.c won't detect the keyboard if it can't talk to it.
> > > + if (IRQ_KEYB_MASK & master_inb(INTERRUPT_REG))
> > > + if (q40kbd_port.dev)
> > > + q40kbd_port.dev->interrupt(&q40kbd_port, master_inb(KEYCODE_REG), 0);
> > ^^^^^^^^^
> > where is this defined?
>
> The way it works with the new input code is that it modularized the
> keyboard/mice from the controller chipsets. This file, q40kbd.c is the
> file to sets up the controller chip. For the Q40 we have this as for the
> ix86 we have i8042.c. As for the mouse and keyboard driver themselves you
> pick PS/2 mouse support and AT keyboard support. These drivers are the
> same ones as the ix86 drivers for the mice and keyboard. In theory they
> should work on both platforms. Note the check for dev. This field is
> filled in when we register the keyboard if it is present.
>
> > > + /* allocate the IRQ */
> > > + request_irq(Q40_IRQ_KEYBOARD, keyboard_interrupt, 0, "q40kbd", NULL);
> > ^^^^^^^^^^^^^^^^^^
> > should that be q40kbd_interrupt ?
>
> Yes. Fixed.
-- Vojtech Pavlik SuSE Labs - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Thu Feb 07 2002 - 21:00:15 EST