Re: [PATCH] read() from driverfs files can read more bytes

From: Patrick Mochel (mochel@osdl.org)
Date: Thu Feb 07 2002 - 15:59:50 EST


On Thu, 7 Feb 2002, Alexander Viro wrote:

>
>
> On Thu, 7 Feb 2002, Patrick Mochel wrote:
>
> > It is really nice, but it's too much for the common case. The goal is to
> > have each file export one and only one value. Setting up an iterator is
> > overkill for one value.
>
> You don't have to use the iterator side of that.

Well, I'll be...

I like the seq_ stuff, and the ->read() side of things take care of the
issues discussed in this thread. What's even nicer is that if I convert to
that, driver callbacks become something like either:

int driver_show(struct device * dev, struct seq_file * m)

or

int driver_show(struct device * dev, char * buf)

Have you considered doing write()?

        -pat

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Feb 07 2002 - 21:01:07 EST