Re: [PATCH] __free_pages_ok oops

From: Andrew Morton (akpm@zip.com.au)
Date: Thu Feb 07 2002 - 18:27:25 EST


Andrea Arcangeli wrote:
>
> > Or I'm missing something. Did something change?
>
> as said in the previous email that becomes a buffercache mapped in
> userspace, with refcount > 1 (unfreeable from the vm side), so the
> __free_page from irq will do nothing (it will only decrease the refcount
> of 1 unit, and then the page will be released by the vm). If the
> refcount was 1 instead, then it means the page wasn't in the lru in the
> first place and so the check won't trigger either.

Ah.

If the second try_to_release_page() against the truncated page
(in shrink_cache()) succeeds, the page is removed from the LRU.

OK, I agree the weird case won't trigger the bug. So I think we
agree that we need to run with Hugh's BUG check and do nothing else.

-
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Feb 07 2002 - 21:01:08 EST