Re: ide cleanup

From: Vojtech Pavlik (vojtech@suse.cz)
Date: Sat Feb 09 2002 - 13:35:00 EST

Next message: Gerd Knorr: "[PATCH/RFC] videodev.[ch] redesign"
Previous message: Bill Davidsen: "Re: ide cleanup"
In reply to: Bill Davidsen: "Re: ide cleanup"
Next in thread: Bill Davidsen: "Re: ide cleanup"
Reply: Bill Davidsen: "Re: ide cleanup"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Sat, Feb 09, 2002 at 01:19:58PM -0500, Bill Davidsen wrote:
> On Wed, 6 Feb 2002, Pavel Machek wrote:
>
> > -#ifdef CONFIG_BLK_DEV_PDC4030
> > if (IS_PDC4030_DRIVE) {
> > extern ide_startstop_t promise_rw_disk(ide_drive_t *, struct request *, unsigned long);
> > return promise_rw_disk(drive, rq, block);
> > }
> > -#endif /* CONFIG_BLK_DEV_PDC4030 */
>
> Am I reading this totally wrong, or do you really think it's a good idea
> to test for a drive even if the user didn't configure such hardware?

Well, since IS_PDC4030_DRIVE will always be 0 in that case, the test
will be optimized out ...

-- 
Vojtech Pavlik
SuSE Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Gerd Knorr: "[PATCH/RFC] videodev.[ch] redesign"
Previous message: Bill Davidsen: "Re: ide cleanup"
In reply to: Bill Davidsen: "Re: ide cleanup"
Next in thread: Bill Davidsen: "Re: ide cleanup"
Reply: Bill Davidsen: "Re: ide cleanup"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Fri Feb 15 2002 - 21:00:27 EST