Re: 2.5.4 sound module problem

From: Alan (alan@clueserver.org)
Date: Tue Feb 12 2002 - 22:10:08 EST


On Tuesday 12 February 2002 19:51, Albert Cranford wrote:
> Not sure if this was the same message I received. but here
> is the patch I used to get around my sound problem in
> 2.5.4.

Are you sure this is correct? include/asm/io.h seems to indicate that i/o
addresses for PCI may not map correctly. The sound card I am using is PCI,
not ISA.

Documentation/DMA-mapping.txt says that virt_to_bus is completly depreciated
and nothing should be using it. Well, grepping the kernel source shows that
quite a bit still uses it.

What it looks like, on first glance, is that virt_to_bus was changed for pci
devices to give this error message. (Since that symbol goes nowhere.) That
effects a number of things, not just sound. (A whole bunch of cardbus drivers
I would guess...)

When was this change made? It appears as if they missed a few bits.

Comment: 2.5.4 has been more than a bit rough. Rarely do i see more than one
patch needed just to get it to compile. Not trying to be bitchy about it.
Just a wee bit frustrated...

> Linus, please apply to 2.5.5 pre1
> Later,
> Albert
> --- linux/drivers/sound/dmabuf.c.orig Tue Feb 12 10:12:59 2002
> +++ linux/drivers/sound/dmabuf.c Tue Feb 12 10:15:06 2002
> @@ -113,7 +113,7 @@
> }
> }
> dmap->raw_buf = start_addr;
> - dmap->raw_buf_phys = virt_to_bus(start_addr);
> + dmap->raw_buf_phys = isa_virt_to_bus(start_addr);
>
> for (page = virt_to_page(start_addr); page <=
> virt_to_page(end_addr); page++) mem_map_reserve(page);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Feb 15 2002 - 21:00:52 EST