[PATCH] -- filesystems.c::sys_nfsservctl

From: Craig Christophel (merlin@transgeek.com)
Date: Wed Feb 13 2002 - 15:51:47 EST


Ok guys get ready to flame me....

        The attached patch removes the lock/unlock in this function. Now I am 80%
sure of this one, but would like a word from the kmod maintainer about
whether request_module needs the BKL or not. do_nfsservctl already takes
the BKL inside the function so as long as request_module is safe this pair
can be removed -- effectively making do_nfsservctl responsible for it's own
locking scheme.

        So whoever knows for SURE about request_module, please reply.

========NOT A PATCH --- filesystems.c::sys_nfsservctl================
long
asmlinkage sys_nfsservctl(int cmd, void *argp, void *resp)
{
        int ret = -ENOSYS;
        
        lock_kernel();

        if (nfsd_linkage ||
            (request_module ("nfsd") == 0 && nfsd_linkage))
                ret = nfsd_linkage->do_nfsservctl(cmd, argp, resp);

        unlock_kernel();
        return ret;
}

==================PATCH ATTACHED==========================



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Feb 15 2002 - 21:00:57 EST