On Wed, 13 Feb 2002, Andrew Morton wrote:
> This patch should fix all the remaining .text.exit problems
> which have resulted from recent binutils changes. For all
> files which are accessible to an x86 build.
>...
> --- linux-2.4.18-pre9/drivers/sound/cs4232.c Sun Sep 30 12:26:08 2001
> +++ linux-akpm/drivers/sound/cs4232.c Tue Feb 12 23:47:28 2002
> @@ -277,7 +277,7 @@ void __init attach_cs4232(struct address
> }
> }
>
> -void __exit unload_cs4232(struct address_info *hw_config)
> +void unload_cs4232(struct address_info *hw_config)
> {
> int base = hw_config->io_base, irq = hw_config->irq;
> int dma1 = hw_config->dma, dma2 = hw_config->dma2;
>...
unload_cs4232 is __exit
the only non-__exit caller of unload_cs4232 is cs4232_isapnp_remove
the only caller of cs4232_isapnp_remove (cleanup_cs4232) is __exit
Am I right to assume that the following alternative patch is correct, too?
--- drivers/sound/cs4232.c.old Wed Feb 6 15:23:55 2002
+++ drivers/sound/cs4232.c Wed Feb 6 17:48:35 2002
@@ -460,7 +460,7 @@
return 0;
}
-int cs4232_isapnp_remove(struct pci_dev *dev, const struct isapnp_device_id *id)
+int __exit cs4232_isapnp_remove(struct pci_dev *dev, const struct isapnp_device_id *id)
{
struct address_info *cfg = (struct address_info*)pci_get_drvdata(dev);
if (cfg) unload_cs4232(cfg);
cu
Adrian
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Fri Feb 15 2002 - 21:01:01 EST