Re: small IDE cleanup: void * should not be used unless neccessary

From: Vojtech Pavlik (vojtech@suse.cz)
Date: Sat Feb 16 2002 - 03:07:15 EST

Next message: Zwane Mwaikambo: "[PATCH][2.5-ALSA] Power Management for es18xx"
Previous message: Andrew Morton: "Re: [patch] get_request starvation fix"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Fri, Feb 15, 2002 at 05:08:20PM -0800, Andre Hedrick wrote:

> > > I know they're functionally equivalent, but so was the original void
> > > *. :)
> >
> > Well, void * hides real errors.
> >
> > > Just an "as long as you're touching this line anyway, why leave the old
> > > comment?" thing. A minor, in-passing nit at best...
> >
> > ide_hwgroup_t is used in 90% of rest of code, so I thought I better
> > leave it there.
>
> So what do we do with the other 10% break it? Sheesh :-/

The other 10% won't break by the change, of course.

-- 
Vojtech Pavlik
SuSE Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Zwane Mwaikambo: "[PATCH][2.5-ALSA] Power Management for es18xx"
Previous message: Andrew Morton: "Re: [patch] get_request starvation fix"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sat Feb 23 2002 - 21:00:10 EST