On Wed, 6 Mar 2002 17:52:03 -0800
Richard Henderson <rth@twiddle.net> wrote:
> On Mon, Mar 04, 2002 at 02:55:36PM +1100, Rusty Russell wrote:
> > + /* If we take the semaphore from 1 to 0, it's ours. */
> > + while (!atomic_dec_and_test(count)) {
> > + if (signal_pending(current)) {
> > + retval = -EINTR;
> > + break;
>
> This is not safe from wraparound. Let one thread hold the
> lock forever; let other threads keep trying to take the lock
> while periodically getting SIGALRM. Eventually one of the
> spinning threads will incorrectly acquire the mutex.
Yes, this was noted. And yes, it's about time we fixed sparc32
or threw it out of the tree. But since the real problem here is
"lock held forever", so I don't care.
> You really do need that cmpxchg loop.
Well, not decrementing if count < 0 already also works (as seen in
later patches), and I'm not going to break those SMP 386s if I don't
have to.
Cheers!
Rusty.
PS. Will Alpha have to do any special magic with the mmap PROT_SEM flag?
-- Anyone who quotes me in their sig is an idiot. -- Rusty Russell. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Thu Mar 07 2002 - 21:00:59 EST